simpler tree-sitter rope provider #10486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ropey’s `Chunks` iterator iterates over `&str` which implements `AsRef<[u8]>` as required by tree-sitter’s `TextProvider`. In consequence it is possible to use ropey’s `Chunks` directly as iterator and save a few lines of code!
|
changes look fine to me but I am working on removing this code entirely and using the tree sitter raw C API directly (#10286) so I would rather keep the code unchanged to avoid merge conflicts since this doesn't improve anything observable by the enduser |
|
sure, that’s just a minor improvement I noticed while looking at how tree-sitter is used with ropey in helix :-) |
|
Alright then I am going to close this. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ropey’s
Chunksiterator iterates over&strwhich implementsAsRef<[u8]>as required by tree-sitter’sTextProvider. In consequenceit is possible to use ropey’s
Chunksdirectly as iterator and save afew lines of code!