Skip to content

PR #7264 has seemingly broken the file picker #7379

Closed
@jchand99

Description

Summary

PR #7264 seemingly has broken the file picker.

The UI shows up, but the picker doesn't get focus.

Reproduction Steps

I tried this:

  1. hx .

I expected this to happen:

I expected helix to open with the file picker UI of the directory I am currently in with focus allowing me to type the name of the file I would like to open first and/or hit the escape key to exit the file picker UI and use the sctach buffer.

Instead, this happened:

The file picker UI opens, but the focus is on the scratch buffer behind the file picker UI without a way to close the UI
Screenshot 2023-06-18 at 23 49 49

As you can see in the screenshot, the cursor is in focus on the scratch buffer behind the file picker UI.

Helix log

~/.cache/helix/helix.log
2023-06-18T23:31:44.454 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:31:44.454 helix_view::theme [WARN] Theme: malformed ANSI: statusline2
2023-06-18T23:31:44.454 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:31:48.488 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:31:48.488 helix_view::theme [WARN] Theme: malformed ANSI: statusline2
2023-06-18T23:31:48.488 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:42:21.497 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:42:21.497 helix_view::theme [WARN] Theme: malformed ANSI: statusline2
2023-06-18T23:42:21.497 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:49:38.322 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:49:38.322 helix_view::theme [WARN] Theme: malformed ANSI: statusline2
2023-06-18T23:49:38.322 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:51:18.681 helix_view::theme [WARN] Theme: malformed ANSI: statusline1
2023-06-18T23:51:18.681 helix_view::theme [WARN] Theme: malformed ANSI: statusline2
2023-06-18T23:51:18.681 helix_view::theme [WARN] Theme: malformed ANSI: statusline1

These log messages seem to be unrelated to the file-picker and potentially related to PR #5119

Platform

macOS

Terminal Emulator

alacritty 0.12.1

Helix Version

22.08.1-1397-g06d63d6a

Metadata

Assignees

Labels

C-bugCategory: This is a bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions