Renaming lifetimes doesn't work (protocol error: InvalidParams: Invalid name pallete_view: not a lifetime identifier)

[dogunbound]

Summary

Make a struct with lifetime requirements. Try renaming them with <space>-r. You should get this error: protocol error: InvalidParams: Invalid name pallete_view: not a lifetime identifier

2023-02-19.16-40-14.mp4

Reproduction Steps

Open file with helix

make a struct with lifetimes, or use this one:

struct MyStruct<'lifetime_1> {
  m: &'lifetime_1 i32
}

Try renaming 'lifetime_1 to 'a with <space>-r

Helix log

helix.log

Platform

Linux

Terminal Emulator

Konsole

Helix Version

22.12

[poliorcetics]

What’s your Rust-analyzer version ?

[dogunbound]

What’s your Rust-analyzer version ?

[dogunbound@archlinux ~]$ rust-analyzer --version
rust-analyzer 1.66.1 (90743e7 2023-01-10)

[poliorcetics]

Could you try it with the most recent one (either building it from source or using the latest release), to see if you reproduce ?

[dogunbound]

Could you try it with the most recent one (either building it from source or using the latest release), to see if you reproduce ?

[dogunbound@archlinux ~]$ rust-analyzer --version
rust-analyzer 1.67.1 (d5a82bb 2023-02-07)

Still getting: protocol error: InvalidParams: Invalid name a: not a lifetime identifier

[the-mikedavis]

It looks like rust-analyzer needs the ' in the lifetime replacement's name: 'a works fine for me but a alone gives this error. This behavior is in rust-analyzer though rather than Helix

[dogunbound]

It looks like rust-analyzer needs the ' in the lifetime replacement's name: 'a works fine for me but a alone gives this error. This behavior is in rust-analyzer though rather than Helix

As true as this is, helix isn't telling my I need the ' character, nor does it automatically put a ' character at the front of the replace. This is a helix bug imo

[the-mikedavis]

You would expect to see 'lifetime_1 in the prompt then, right?

This was discussed a bit in #2459: we use the current word as an approximation of the symbol. Adding support for LSP Prepare Rename (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename) would most likely give us the range of 'lifetime_1 for this request and then we could use that range to fill in the renaming prompt.

[dogunbound]

You would expect to see 'lifetime_1 in the prompt then, right?

This was discussed a bit in #2459: we use the current word as an approximation of the symbol. Adding support for LSP Prepare Rename (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename) would most likely give us the range of 'lifetime_1 for this request and then we could use that range to fill in the renaming prompt.

It's a helix issue to not auto-fill the rename with '. When you do <space>-r, it will fill it with lifetime_name, but it should fill it with 'lifetime_name. Atleast hint that it needs the' character in the front of it.

[dogunbound]

2023-02-20.17-41-37.mp4

[pascalkuthe]

Helix has no concept of a lifetime or anything rust/language specific. As @the-mikedavis said the way to implement this is to add support for https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename to helix.

I don't think word would work as ' is not part of word only WORD (which we don't want to use here I think)