Removing a bracket removes more than one bracket

[Jomy10]

Summary

In this short video, I delete a closing bracket, but it also removes the closing bracket to the right of it.

Schermopname.2022-10-31.om.20.14.09.mov

Reproduction Steps

type something like (()) in helix. Remove the third bracket with backspace, the last one will disappear as well.

Helix log

No response

Platform

macOS

Terminal Emulator

iTerm2

Helix Version

helix 22.08.1 (f41f28b)

[David-Else]

This problem trips me up often too.

[ygabuev]

#4558 is the change that fixes the issue.

However, there is still a problem with AutoPairs: they are annotated to be keyed by the opener:

helix/helix-core/src/auto_pairs.rs

Lines 19 to 22 in 8ff92c7

	/// The type that represents the collection of auto pairs,
	/// keyed by the opener.
	#[derive(Debug, Clone)]
	pub struct AutoPairs(HashMap<char, Pair>);

but the new() method also adds closers as keys:

helix/helix-core/src/auto_pairs.rs

Lines 90 to 91 in 8ff92c7

	if auto_pair.open != auto_pair.close {
	auto_pairs.insert(auto_pair.close, auto_pair);

This might be the issue why the bug was introduced in the first place - the contributor assumed that there are no closers in the list of keys of an AutoPairs instance.