Greater than 99999 line file doesn't resize line number width

[dalanmiller]

Summary

When viewing a file that has more than 99,999 lines, anything more than the left five digits is squelched.

E.g. my /etc/hosts file.

This gets quite confusing when viewing lines much higher:

Reproduction Steps

Download this file:

100001.txt

:100001 and observe the line numbers being truncated.

Helix log

Probably not necessary? I didn't see any issues related.

Platform

macOS

Terminal Emulator

iterm2

Helix Version

helix 22.03 (d4e45fd)

[the-mikedavis]

The line number gutter has a fixed, constant width currently:

helix/helix-view/src/view.rs

Line 104 in efae761

GutterType::LineNumbers => gutters.push((gutter::line_numbers, 5)),

Some ways to go about fixing this:

• make the fixed-width configurable instead of a constant
• make the width dynamic based on the line numbers within view or the maximum line number of the buffer

[EpocSquadron]

I vote for the second, within buffer. Would save some space in smaller files. However I wonder if we keep the limit but cut off the beginning digits with an ellipsis character to avoid going nuts with space usage in massive files.

[archseer]

Resolved by #2583