Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: differentiate --health output by more than just colour #1894

Closed
aral opened this issue Mar 30, 2022 · 0 comments · Fixed by #1947
Closed

Accessibility: differentiate --health output by more than just colour #1894

aral opened this issue Mar 30, 2022 · 0 comments · Fixed by #1947
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed

Comments

@aral
Copy link
Contributor

aral commented Mar 30, 2022

The problem

Output from --health command is differentiated only by colour (red: not installed/found, green: found)

Suggested improvement

Add a ✘ or ✔ next to the items.

(Red/green is a common form of colourblindness so some people will not otherwise be able to tell them apart.)
@aral aral added the C-enhancement Category: Improvements label Mar 30, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Mar 30, 2022
@sudormrfbin sudormrfbin added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Extra attention is needed E-good-first-issue Call for participation: Issues suitable for new contributors labels Mar 30, 2022
@Simon-Hostettler Simon-Hostettler mentioned this issue Apr 1, 2022
Merged
@archseer archseer reopened this Apr 2, 2022
nirmal-j-patel added a commit to nirmal-j-patel/helix that referenced this issue Apr 3, 2022
@nirmal-j-patel
Add true or false checkbox in health output table
391c8bf 
hx --health output table's second and third columns were not showing
symbols like ✔ or ✘ to indicate whether LSP or DAP binaries were found.
This change adds these symbols to improve accessibility.

Fixes helix-editor#1894

Signed-off-by: Nirmal Patel <npate012@gmail.com>
@nirmal-j-patel nirmal-j-patel mentioned this issue Apr 3, 2022
Merged
nirmal-j-patel added a commit to nirmal-j-patel/helix that referenced this issue Apr 5, 2022
@nirmal-j-patel
Add true or false checkbox in health output table
27b31c9 
hx --health output table's second and third columns were not showing
symbols like ✔ or ✘ to indicate whether LSP or DAP binaries were found.
This change adds these symbols to improve accessibility.

Fixes helix-editor#1894

Signed-off-by: Nirmal Patel <npate012@gmail.com>
archseer pushed a commit that referenced this issue Apr 12, 2022
@nirmal-j-patel
Add true or false checkbox in health output table (#1947)
3deb1c9 
hx --health output table's second and third columns were not showing
symbols like ✔ or ✘ to indicate whether LSP or DAP binaries were found.
This change adds these symbols to improve accessibility.

Fixes #1894

Signed-off-by: Nirmal Patel <npate012@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add true or false checkbox in health output table nirmal-j-patel/helix
4 participants
@aral @archseer @the-mikedavis @sudormrfbin