Don't add empty prompt input to history (#3259)

helix-editor · Jul 30, 2022 · 5ca98ed · 5ca98ed
1 parent a8b123f
commit 5ca98ed
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/helix-term/src/ui/prompt.rs b/helix-term/src/ui/prompt.rs
@@ -533,16 +533,17 @@ impl Component for Prompt {
                             .map(|entry| entry.into())
                             .unwrap_or_else(|| Cow::from(""))
                     } else {
+                        if let Some(register) = self.history_register {
+                            // store in history
+                            let register = cx.editor.registers.get_mut(register);
+                            register.push(self.line.clone());
+                        }
+
                         self.line.as_str().into()
                     };
 
                     (self.callback_fn)(cx, &input, PromptEvent::Validate);
 
-                    if let Some(register) = self.history_register {
-                        // store in history
-                        let register = cx.editor.registers.get_mut(register);
-                        register.push(self.line.clone());
-                    }
                     return close_fn;
                 }
             }