handle splits more elegantly

helix-editor · Aug 23, 2021 · 22c07af · 22c07af
1 parent 07c5152
commit 22c07af
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs
@@ -1908,11 +1908,12 @@ mod cmd {
         let (_, doc) = current!(cx.editor);
         let id = doc.id();
 
-        cx.editor.switch(id, Action::VerticalSplit);
-
-        let path = args.get(0).context("wrong argument count")?;
+        if let Some(path) = args.get(0) {
+            cx.editor.open(path.into(), Action::VerticalSplit)?;
+        } else {
+            cx.editor.switch(id, Action::VerticalSplit);
+        }
 
-        let _ = cx.editor.open(path.into(), Action::Replace)?;
         Ok(())
     }
 
@@ -1924,11 +1925,12 @@ mod cmd {
         let (_, doc) = current!(cx.editor);
         let id = doc.id();
 
-        cx.editor.switch(id, Action::HorizontalSplit);
-
-        let path = args.get(0).context("wrong argument count")?;
+        if let Some(path) = args.get(0) {
+            cx.editor.open(path.into(), Action::HorizontalSplit)?;
+        } else {
+            cx.editor.switch(id, Action::HorizontalSplit);
+        }
 
-        let _ = cx.editor.open(path.into(), Action::Replace)?;
         Ok(())
     }