Update settings to have more default values and be able to to override with env variables #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbalser
force-pushed
the
bbalser/better-configs
branch
from
95344a9 to
cfdae3b
Compare
michaeldjeffrey
force-pushed
the
bbalser/better-configs
branch
3 times, most recently
from
4bcdddf to
90426a6
Compare
We want to make sure we can provide JSON through env variables. So we test constructing price::Settings with default values, and the rest coming from the environment in the same way starting up a server expects them. - Remove `Settings::tokens()` - The field is not correctly parsed when the Settings are parsed. - Add `temp-env` crate as a dev-dependency - his allows us to define environment variables in a test without need ing to worry about cleanup manually. - Add `from_json_or_struct` deserializer - Takes an env var and parses it as JSON, or the struct it’s expecting
michaeldjeffrey
force-pushed
the
bbalser/better-configs
branch
from
90426a6 to
f42dca4
Compare
michaeldjeffrey
approved these changes
Aug 19, 2025
kurotych
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.