-
Notifications
You must be signed in to change notification settings - Fork 34
Description
When working on our integration with the config-service I was debugging some issues we had with the new signer field, and while looking at some wireshark logs, I noticed some request/response data was clearly readable and thus not encrypted.
I assumed by using grpc everything was encrypted using ssl/tls, but it turns out this is not the case.
Sure all requests are signed, and authenticated .. but if someone manages to intercept traffic to/from the config service api's, nothing prevents them from replaying the api calls.
Most (not all!) endpoints seem to have a timestamp field in their requests; but it seems there is no logic present to prevent replay attacks.
In my opinion the current situation is not secure enough for our customers needs and I would strongly suggest to add another ssl/tls enabled grpc endpoint. This way existing users of the api could continue to use the insecure grpc endpoint and the newer clients can use the secure grpc endpoint.