Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

only build embedded gateway in miner releases #1471

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

jeffgrunewald
Copy link
Contributor

Validator releases have no business building the embedded gateway-rs or semtech-udp project which add significantly to the build time. This change moves the calls to the associated make tasks that build and cleanup the rust projects into the rebar release profiles for miner builds that do need them as embedded dependencies.

@jeffgrunewald
Copy link
Contributor Author

I see that we're still using the testdev profile for the 8 miner builds that get used in the run.sh script so assuming that's still an active method of testing the miner code we're not able to remove that profile yet, but i don't see the aws release profile in use anywhere so perhaps we could clean that one up?

@evanmcc
Copy link
Contributor

evanmcc commented Mar 7, 2022

yeah, we don't use the AWS profile anymore, that can be removed.

why do we need this in the test profile?

@jeffgrunewald
Copy link
Contributor Author

why do we need this in the test profile?

i'm testing that functionality i'd need them to be available for that; specifically in https://github.com/helium/miner/blob/master/test/miner_gateway_mux_integration_SUITE.erl at the moment but could be elsewhere with future tests as well

@Vagabond
Copy link
Contributor

Vagabond commented Mar 8, 2022

it does seem reasonable to leave it in the test profile.

@Vagabond Vagabond merged commit aebcdd8 into master Mar 11, 2022
@Vagabond Vagabond deleted the jg/contextualize_embedded_gateway branch March 11, 2022 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants