Refactor build system #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayKickliter
force-pushed
the
jsk/cmake
branch
7 times, most recently
from
4d977f5 to
c8090ad
Compare
|
See intentional buffer overflow in action. |
|
I'll look at this closely along with helium/erlang-h3#14 on Tuesday. |
fvasquez
reviewed
Jun 2, 2020
c_src/erasure.c
Outdated
| @@ -67,7 +67,7 @@ encode(ErlNifEnv * env, int argc, const ERL_NIF_TERM argv[]) | |||
| int bytes_per_shard = input.size / k; | |||
| int extra_bytes = input.size % k; | |||
|
|
|||
| char *shards = calloc(k+m, blockspacing); | |||
| char *shards = calloc(k+m, blockspacing-1); | |||
There was a problem hiding this comment.
I added that on purpose to trigger an error. I'll rebase without that commit before merging.
1. switch to cmake for better control of build 2. add compile-time static-analysis 3. add support for santization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See helium/erlang-h3#14 for more details, as this PR is pretty much identical.