Add support for Good General Cauchy Matrices #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate function for encoding using Cauchy GC matrix - Add a common test
- Also update the tests
Vagabond
suggested changes
Jan 7, 2019
c_src/erasure.c
Outdated
| /*int res = jerasure_bitmatrix_decode(k, m, w, bitmatrix, 0, erasures, data_ptrs, coding_ptrs, blocksize, blocksize/w);*/ | ||
| /* This works but ONLY if you don't use smart mode (the last argument set to 1 uses smart mode) | ||
| * smart mode seems to mis-allocate memory for the smart schedule and that causes segfaults */ | ||
| int res = jerasure_schedule_decode_lazy(k, m, w, bitmatrix, erasures, data_ptrs, coding_ptrs, blocksize, blocksize/w, 0); |
There was a problem hiding this comment.
Isn't jerasure_bitmatrix_decode faster than decode_lazy when not using the smart mode?
There was a problem hiding this comment.
Right, so, jerasure_bitmatrix_decode is indeed slightly faster than the dumb mode decode_lazy.
Quick test:
Decoded with jerasure_bitmatrix_decode - Bytes XOR'd: 6752.
jerasure_schedule_decode_lazy - Bytes XOR'd: 5696.
jerasure_schedule_decode_lazy_dumb - Bytes XOR'd: 6888.
Vagabond
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.