Implement proper block padding for 32 bit systems #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ARM (not ARM64) where the sizeof(long) is 4 (vs 8 on 64 bit systems) the GF-Complete requirement that data blocks be aligned on a multiple of 16 bytes can be violated. This patch reworks how we allocate and pad the data shards such that: * All shards are allocated in contiguous memory * The spacing between shards is always a multiple of 16 bytes
lthiery
reviewed
Aug 29, 2018
c_src/erasure.c
Outdated
| @@ -126,19 +134,26 @@ decode(ErlNifEnv * env, int argc, const ERL_NIF_TERM argv[]) | |||
| return enif_make_tuple2(env, enif_make_atom(env, "error"), enif_make_atom(env, "insufficent_shards")); | |||
| } | |||
|
|
|||
| char **shards = malloc(sizeof(char*)*(k+m)); | |||
| char *shards = NULL; | |||
| char **data_ptrs = calloc(k, sizeof(char*)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ARM (not ARM64) where the sizeof(long) is 4 (vs 8 on 64 bit systems)
the GF-Complete requirement that data blocks be aligned on a multiple of
16 bytes can be violated. This patch reworks how we allocate and pad the
data shards such that:
I've run several million quickcheck tests on my amd64 machine and have not found a failure. I have not run EQC on an ARM device, however.