This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Codify implicit sorting of oracle submissions before txn close & fix … #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue The implicit txn ordering behaviour if a transaction did not have a defined sort order can cause instability in the sort order when a new transaction is added, because the undefined sort order was the same as the last sort order. This could lead to the transaction without a defined sort order sorting before the transaction with a defined sort order (because of the other sort dimensions like nonces, etc).This means that adding another transaction to the end of the sort order list would cause the transaction with the implicit sort order to definitely sort after the transaction it may have sorted before earlier, invalidating the block. This change establishes a definitive sort order for the oracle price report txn to mirror the implicit sort order before the addition of the hotspot transfer function. Additionally it makes the undefined sort order one past the maximum to prevent this bug recurring and it add a log message to the sync_handler to make this failure clearer. This *may* expose other implicit sort ordering bugs, so a thorough resync (or at least ordering check of txns in blocks) is recommended.
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 68.40% 68.25% -0.16%
==========================================
Files 94 94
Lines 12311 12312 +1
==========================================
- Hits 8421 8403 -18
- Misses 3890 3909 +19
Continue to review full report at Codecov.
|
jadeallenx
approved these changes
Nov 17, 2020
evanmcc
reviewed
Nov 17, 2020
| @@ -636,7 +637,7 @@ type_order(Txn) -> | |||
| Type = type(Txn), | |||
| case lists:keyfind(Type, 1, ?ORDER) of | |||
| {Type, Index} -> Index; | |||
| false -> erlang:length(?ORDER) | |||
| false -> erlang:length(?ORDER) + 1 | |||
There was a problem hiding this comment.
wouldn't it be safer to just error here?
There was a problem hiding this comment.
We'd have to audit that all other transactions have a defined order and make sure we establish that ordering, but yes.
evanmcc
approved these changes
Nov 17, 2020
vihu
approved these changes
Nov 17, 2020
|
For reference, I was able to successfuly resync with revalidation from block |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issue
The implicit txn ordering behaviour if a transaction did not have a
defined sort order can cause instability in the sort order when a new
transaction is added, because the undefined sort order was the same as
the last sort order. This could lead to the transaction without a
defined sort order sorting before the transaction with a defined sort
order (because of the other sort dimensions like nonces, etc).This means
that adding another transaction to the end of the sort order list would
cause the transaction with the implicit sort order to definitely sort
after the transaction it may have sorted before earlier, invalidating
the block.
This change establishes a definitive sort order for the oracle price
report txn to mirror the implicit sort order before the addition of the
hotspot transfer function. Additionally it makes the undefined sort
order one past the maximum to prevent this bug recurring and it add a
log message to the sync_handler to make this failure clearer.
This may expose other implicit sort ordering bugs, so a thorough
resync (or at least ordering check of txns in blocks) is recommended.