4.x: CORS support helper change log level. #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
changed the title
romain-grecourt
approved these changes
Feb 26, 2025
jbescos
reviewed
Feb 27, 2025
tjquinno
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Info log level is only for a very limited number of messages that must be agreed on in advance.
Configuration of CORS is not such a type of message. It may be printed multiple times if used directly by the user, and in general this does not seem to be a relevant information that MUST be printed on each startup.
I have switched the level to
DEBUG, which is the next level.This can always be easily enabled by changing the log level of this logger to verify the configuration when/if needed.