Connection cache 100 continue #9795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verdent
requested review from
danielkec,
romain-grecourt,
spericas and
tomas-langer
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
reviewed
Feb 14, 2025
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Outdated
Show resolved
Hide resolved
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Outdated
Show resolved
Hide resolved
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Show resolved
Hide resolved
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Outdated
Show resolved
Hide resolved
tomas-langer
previously approved these changes
Feb 21, 2025
tomas-langer
previously approved these changes
Feb 21, 2025
webclient/api/src/main/java/io/helidon/webclient/api/ClientConnection.java
Outdated
Show resolved
Hide resolved
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Outdated
Show resolved
Hide resolved
spericas
reviewed
Feb 24, 2025
common/socket/src/main/java/io/helidon/common/socket/IdleInputStream.java
Show resolved
Hide resolved
tomas-langer
previously approved these changes
Feb 24, 2025
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
force-pushed
the
connection-cache-100-continue
branch
from
dfa0a95 to
4795240
Compare
tomas-langer
approved these changes
Feb 24, 2025
romain-grecourt
approved these changes
Feb 24, 2025
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Feb 25, 2025
Signed-off-by: David Kral <david.k.kral@oracle.com>
barchetta
added a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9736
Fixes #9731
This issue introduces a new way of idle connection handling. It splits the desired idle timeout and uses small 500 ms timeouts until the overall desired timeout is reached. This helps to interrupt the idle timeout mechanism.
FYI: I will add some more comments to the code
Documentation
None