Restore setting of no-cache header in health HTTP responses; add test #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
requested review from
ljnelson,
spericas,
barchetta and
tomas-langer
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Feb 7, 2025
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9670
Release note:
Formerly (in 3.x) HTTP responses from the health endpoint set the
Cache-Controlheader tono-cache, no-store, must-revalidate, no-transformbecause the returned result could well be different for each request. But 4.x does not do so. This change restores those response header values.This PR Restores the addition of the no-cache group of headers to the health response that was seemingly accidentally dropped in the move to 4.x.
Adds test checking for the header values.
Documentation
Bug fix. No doc impact.