4.1.3: Fix DataReader.findNewLine with multiple lone EOL character #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io#9362) When there is multiple lone CR within a buffer, the virtual index is accumulated each time with the node index. The virtual index may be incorrectly seen as >= max, which ignores CRLN within max. - Fix virtual index accumulation - Re-use the branch that changes the buffer - Renamed indexWithinNode -> fromIndexNode - Renamed crIndex -> crIndexNode - Renamed lfIndex -> lfIndexNode - Add unit tests
barchetta
added
webserver
backport
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9362 to Helidon 4.1.3
Description
DataReader.findNewLinereturns max instead of new line index when there are multiple lone CR characters in the same buffer.E.g.
\r\r\r\nThe virtual index is incorrectly accumulated each time with the relative index, its value may exceed max which will skip any valid CRLN within max.
Fixes #9365
Documentation
None.