Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures chunked encoding is enabled in all cases when there are trailers #9334

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Oct 7, 2024

Description

Ensures chunked encoding is enabled whenever there are trailers to be sent, even if a Content-Length header was specified. Note that trailers can only be sent when chunked encoding is used. New test that adds a trailer and sets a Content-Length header. See issue #9243.

Documentation

None

… sent, even if a Content-Length header was specified. New test that adds a trailer and sets a Content-Length header.
@spericas spericas added website 4.x Version 4.x labels Oct 7, 2024
@spericas spericas added this to the 4.1.3 milestone Oct 7, 2024
@spericas spericas self-assigned this Oct 7, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 7, 2024
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 9c2cafa into helidon-io:main Oct 8, 2024
44 checks passed
@spericas spericas mentioned this pull request Oct 8, 2024
16 tasks
barchetta pushed a commit to barchetta/helidon that referenced this pull request Oct 11, 2024
… sent, even if a Content-Length header was specified. New test that adds a trailer and sets a Content-Length header. (helidon-io#9334)
barchetta added a commit that referenced this pull request Oct 11, 2024
… sent, even if a Content-Length header was specified. New test that adds a trailer and sets a Content-Length header. (#9334) (#9370)

Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. website
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants