4.x: Inject update - collateral #8281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
added
4.x
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
force-pushed
the
7957-inject-collateral-3
branch
from
5cef857 to
1d761e0
Compare
There was a problem hiding this comment.
Minors comments:
Some files only have copyright changes:
- inject/configdriven/runtime/src/main/java/io/helidon/inject/configdriven/runtime/package-info.java
- inject/configdriven/processor/src/main/java/module-info.java
- inject/api/src/main/java/io/helidon/inject/spi/package-info.java
The deprecation for builder/processor is only described in builder/processor/pom.xml
|
Some of the files were touched due to git operation (it thought something was a move even if it was not). As a result, those files have activity reported in git, so they must have updated copyright. |
Refactoring of modules to use new builder codegen (remove use of config metadata for builders) Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
7957-inject-collateral-3
branch
from
2dc6390 to
479d106
Compare
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
|
Fixed copyright issue (squashed commits to remove the change). |
romain-grecourt
approved these changes
Jan 25, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
* Introduction of codegen modules * Refactoring of modules to use new builder codegen (remove use of config metadata for builders) * Deprecated old processor modules (such as builder processor) Co-authored-by: Daniel Kec <daniel.kec@oracle.com> Co-authored-by: Jeff Trent <jeff.trent@oracle.com> Co-authored-by: David Kral <david.kral@oracle.com> Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
* Introduction of codegen modules * Refactoring of modules to use new builder codegen (remove use of config metadata for builders) * Deprecated old processor modules (such as builder processor) Co-authored-by: Daniel Kec <daniel.kec@oracle.com> Co-authored-by: Jeff Trent <jeff.trent@oracle.com> Co-authored-by: David Kral <david.kral@oracle.com> Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7957
Changes
io.helidon.config:helidon-config-metadata@io.helidon.config.metadata.Configuredand@io.helidon.config.metadata.ConfiguredOption@io.helidon.builder.api.Option.Configuredand@io.helidon.builder.api.Option.Default*@io.helidon.builder.api.Prototype.Configuredand@io.helidon.builder.api.Prototype.ProvidesDeprecations
Mark modules as deprecated since 4.1.0 and to be removed in 5.0.0.
New modules