3.x - Slightly relax a unit test to avoid test ordering issues #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T LEAST once instead of exactly once to avoid test ordering issues
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
changed the title
barchetta
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8123
The purpose of the test is to make sure that a metric is registered and updated via a stereotype annotation which itself bears metrics annotations.
The counter value associated with the simple timer in the failing test can be updated multiple times during the course of all units tests (because it is on a bean).
The change in the PR slightly relaxes the test to make sure the simple timer's counter is AT LEAST 1 instead of exactly 1. If it is non-zero then clearly the meter was, in fact, registered and updated, satisfying the purpose of the test.
Documentation
Test bug fix. No doc impact.