Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webclient redesign #7255

Merged
merged 21 commits into from
Jul 31, 2023
Merged

Webclient redesign #7255

merged 21 commits into from
Jul 31, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jul 27, 2023 •
edited
Loading

WebClient redesign

Resolves:

Follow up issue: #7269

Notable changes:

  • single API that can run any HTTP version
  • upgrade done through HTTP/1.1 client always (implemented both for WebSocket and HTTP/2)
  • HTTP client SPI (HTTP/1.1 and HTTP/2 implementations)
  • Client SPI (websocket implementation)
  • Cookie manager support for HTTP/1.1 and HTTP/2
  • WebClientService support for HTTP/1.1 and HTTP/2
  • HttpClientResponse.request(Class) now returns a typed entity response, HttpClientResponse.requestEntity(Class) returns only the response entity (and throws if non-success status family)

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 27, 2023
tomas-langer and others added 16 commits July 28, 2023 13:34
@tomas-langer
WebClient, HTTP/1.1 webclient aligned
e72c3c2
@tomas-langer
HTTP/2 webclient alignment (in progress)
839ac3c
@tomas-langer
Fixes after rebase (on reactive removal)
811b736
@tomas-langer
Fix for helidon-io#7223
16029a1
@tomas-langer
Use UriInfo in WebClient, combined query and fragment with it
3229698
@tomas-langer @spericas
Cookie support for webclient.
3a36581 
Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Co-authored-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
WebSocket now upgrades through API
d6a2bf2
@tomas-langer
HTTP/2 with services.
6c8c125
@tomas-langer
Change to service execution to support both versions of http
8c2e953
@tomas-langer
HTTP/2 and WebSocket test fixes
9f5ab4c
@tomas-langer
Typed client response fixes (so it does not need to be autocloseable)
899d002
@tomas-langer
Fix client entity reading, when chunked received over the network is …
004d7eb 
…bigger than buffer used to read it.
@tomas-langer
Copyright fixes
bb26018
@tomas-langer
Fixed all tests and examples.
b187167
@tomas-langer
Checkstyle fixes
28ea46f
@tomas-langer
Fixes after rebasing on latest main
33933c7
@tomas-langer tomas-langer force-pushed the 6669-webclient-redesign branch from 7ed0999 to 33933c7 Compare July 28, 2023 11:37
@tomas-langer tomas-langer marked this pull request as ready for review July 28, 2023 11:37
trentjeff
trentjeff reviewed Jul 28, 2023
View reviewed changes
...vault/auths/common/src/main/java/io/helidon/integrations/vault/auths/common/NoVaultAuth.java Show resolved Hide resolved
...ions/vault/auths/k8s/src/main/java/io/helidon/integrations/vault/auths/k8s/K8sVaultAuth.java Show resolved Hide resolved
jersey/connector/src/main/java/io/helidon/jersey/connector/HelidonConnector.java Show resolved Hide resolved
...narayana-client/src/main/java/io/helidon/lra/coordinator/client/narayana/NarayanaClient.java Show resolved Hide resolved
nima/common/tls/src/main/java/io/helidon/nima/common/tls/Tls.java Outdated Show resolved Hide resolved
nima/http2/webclient/src/main/java/io/helidon/nima/http2/webclient/Http2CallChainBase.java
Http2ClientProtocolConfig protocolConfig,
Http2ClientRequestImpl clientRequest,
CompletableFuture<WebClientServiceResponse> whenComplete,
Function<Http1ClientRequest, Http1ClientResponse> http1EntityHandler) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consistent CRLF's

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your comment.

nima/http2/webclient/src/main/java/io/helidon/nima/http2/webclient/Http2ClientRequestImpl.java Outdated Show resolved Hide resolved
...n/http2/client/src/test/java/io/helidon/nima/tests/integration/http2/client/HeadersTest.java Show resolved Hide resolved
...ebclient/webclient/src/test/java/io/helidon/nima/tests/integration/webclient/CookieTest.java Show resolved Hide resolved
nima/webclient/api/src/main/java/io/helidon/nima/webclient/api/ClientResponseTyped.java Show resolved Hide resolved
This was referenced Jul 31, 2023
Closed
Closed
This was referenced Jul 31, 2023
Closed
Closed
spericas
spericas approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement over previous API!

@tomas-langer tomas-langer mentioned this pull request Jul 31, 2023
Closed
@tomas-langer tomas-langer merged commit 39b644b into helidon-io:main Jul 31, 2023
@tomas-langer tomas-langer deleted the 6669-webclient-redesign branch July 31, 2023 19:31
@tomas-langer
Copy link
Member Author

Updated #7269 with unresolved comments from this PR (except for the inconsistent CR/LF as I cannot find what is wrong)

@Verdent Verdent mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentjeff trentjeff trentjeff left review comments

@spericas spericas spericas approved these changes

@danielkec danielkec danielkec approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@tomas-langer tomas-langer

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomas-langer @danielkec @spericas @trentjeff