Constructors are now intercepted with appropriate interceptors only. #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for additional use cases (commented out the failing ones + added issue)
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
commented
Apr 18, 2023
| @@ -118,18 +118,18 @@ public static <T> List<Provider<T>> mergeAndCollapse(List<Provider<T>>... lists) | |||
|
|
|||
| @Override | |||
| public V proceed(Object... args) { | |||
| if (!interceptorIterator.hasNext()) { | |||
| if (interceptorIterator.hasNext()) { | |||
There was a problem hiding this comment.
it is easier to reason about an if statement if negation is not used (and I had to debug this method a lot).
This is a best practice we use in Helidon, fixed this instance as PR is related.
Reverted template to create multiline
trentjeff
approved these changes
Apr 18, 2023
...interception/src/test/java/io/helidon/pico/tests/interception/InterfaceInterceptionTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6632
Added tests for additional use cases (commented out the failing ones + added issue)
Created #6647