Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement #6512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and replacement Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Tangentially related to #4928. |
tjquinno
reviewed
Mar 29, 2023
integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/JpaExtension.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
tjquinno
approved these changes
Mar 29, 2023
ljnelson
added a commit
to ljnelson/helidon
that referenced
this pull request
Aug 23, 2023
… and replacement (helidon-io#6512) Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
added a commit
that referenced
this pull request
Aug 25, 2023
* Improves integrations/jdbc/jdbc to better support future JPA improvements; initial work (#5654) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; initial work (#5716) Lays some groundwork with deprecation and cleanup and isolated improvements to support ongoing JPA improvements. Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Introduces LocalXAResource and a few support classes in jta/jdbc. (#5733) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds connection unwrapping abilities to CDISEPlatform.java (#5790) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Introduces JtaConnection.java (#5905) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Fixes erroneous closing behavior in JtaConnection.java (#6321) * Fixes erroneous closing behavior in JtaConnection.java Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Minor JPA cleanups; part of overall refactoring effort (#6435) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Improving JPA pom.xml as part of overall JPA refactoring (#6508) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Fixes merge conflicts etc. from cherry-pick of c9a849e Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement (#6512) Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds more classes as part of overall JPA refactoring effort (#6584) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Lets unit tests validating JpaExtension and unit tests validating PersistenceExtension run side-by-side; continuation of overall fix for nested transaction problems (#7118) * Lets unit tests validating JpaExtension and unit tests validating PersistenceExtension run side-by-side; continuation of overall fix for nested transaction problems Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Resolves issue 7316, which features some intermittent database-related tests (#7317) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Addresses copyright plugin complaints after lots of cherry-picking from old 3.x commits Signed-off-by: Laird Nelson <laird.nelson@oracle.com> --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Aug 26, 2023
* Improves integrations/jdbc/jdbc to better support future JPA improvements; initial work (helidon-io#5654) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; initial work (helidon-io#5716) Lays some groundwork with deprecation and cleanup and isolated improvements to support ongoing JPA improvements. Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Introduces LocalXAResource and a few support classes in jta/jdbc. (helidon-io#5733) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds connection unwrapping abilities to CDISEPlatform.java (helidon-io#5790) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Introduces JtaConnection.java (helidon-io#5905) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Fixes erroneous closing behavior in JtaConnection.java (helidon-io#6321) * Fixes erroneous closing behavior in JtaConnection.java Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Minor JPA cleanups; part of overall refactoring effort (helidon-io#6435) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Improving JPA pom.xml as part of overall JPA refactoring (helidon-io#6508) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Fixes merge conflicts etc. from cherry-pick of c9a849e Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement (helidon-io#6512) Adds an enabled flag to JpaExtension to permit subsequent refactoring and replacement Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Adds more classes as part of overall JPA refactoring effort (helidon-io#6584) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Lets unit tests validating JpaExtension and unit tests validating PersistenceExtension run side-by-side; continuation of overall fix for nested transaction problems (helidon-io#7118) * Lets unit tests validating JpaExtension and unit tests validating PersistenceExtension run side-by-side; continuation of overall fix for nested transaction problems Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Resolves issue 7316, which features some intermittent database-related tests (helidon-io#7317) Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Addresses copyright plugin complaints after lots of cherry-picking from old 3.x commits Signed-off-by: Laird Nelson <laird.nelson@oracle.com> --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
JpaExtensionto be disabled so that eventually it can coexist alongside its replacement. That way if anything goes wrong with the future machinery a user in the field can roll back to this implementation without waiting on a new release from Helidon or having to avoid upgrading.This PR also brings the class into conformance with our development guidelines. Less stuffily,
finals have been removed and comments have been formatted for easier reading.