Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: cleanup pom files with duplicate declarations of maven-compiler-plugin #5810

Merged
merged 1 commit into from
Jan 9, 2023
Merged

4.x: cleanup pom files with duplicate declarations of maven-compiler-plugin #5810

merged 1 commit into from
Jan 9, 2023

Conversation

barchetta
Copy link
Member

Fixes #5806

@barchetta barchetta added build 4.x Version 4.x labels Jan 9, 2023
@barchetta barchetta self-assigned this Jan 9, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2023
tjquinno
tjquinno approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit 71ca736 into helidon-io:main Jan 9, 2023
@barchetta barchetta deleted the 4.x-pom-compiler-plugin branch May 31, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
4.x Version 4.x build OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @tjquinno