HTTP upgrade handler for Websockets #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface. Updated sample to show use case thatnegotiates a sub-protocol. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…s not support adding the extensions header manually so only server-side code updated.
|
Related to #5422 |
tomas-langer
requested changes
Dec 20, 2022
...websocket/webserver/src/main/java/io/helidon/nima/websocket/webserver/WsUpgradeProvider.java
Outdated
Show resolved
Hide resolved
...websocket/webserver/src/main/java/io/helidon/nima/websocket/webserver/WsUpgradeProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
tomas-langer
requested changes
Jan 5, 2023
nima/websocket/webserver/src/main/java/io/helidon/nima/websocket/webserver/WsConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Jan 10, 2023
This was referenced Jan 10, 2023
|
Changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for an HTTP upgrade handler that is part of the WsListener interface. Updated sample to show use case that negotiates a sub-protocol.
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com