-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP on Níma #5176
Merged
Merged
MP on Níma #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored all usages. Initial switch to Níma in MP
refactored for Níma, SE and MP
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
previously approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over it quickly. IMO this sort of PR does not need to be perfect. We should merge it as soon as the pipeline passes for future work to be possible.
I am working on fixes of packaging. Getting there (discovered a bug in Jersey integration) |
danielkec
reviewed
Oct 14, 2022
...ometer/micrometer/src/main/java/io/helidon/integrations/micrometer/MeterRegistryFactory.java
Outdated
Show resolved
Hide resolved
danielkec
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicroProfile running on Níma server.
There are a few things disabled to be fixed later, I will create follow up issues:
tck-metrics commented out
tck-jwt-auth commented out
tck-opentracing commented out
tck-lra commented out
Disabled:
grpc/metrics/src/test/java/io/helidon/grpc/metrics/GrpcMetricsInterceptorIT.java
grpc/metrics/src/test/java/io/helidon/grpc/metrics/MetricsIT.java
microprofile/cors/src/test/java/io/helidon/microprofile/cors/AdapterTest.javad
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestDisabledMetrics.java
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestExtendedKPIMetrics.java
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestMetricsOnOwnSocket.java
microprofile/server/src/test/java/io/helidon/microprofile/server/JerseyPropertiesTest.java
microprofile/server/src/test/java/io/helidon/microprofile/server/ServerSseTest.java
nima/openapi/src/test/java/io/helidon/nima/openapi/ServerTest.java
nima/openapi/src/test/java/io/helidon/nima/openapi/TestCors.java
reactive/openapi/src/test/java/io/helidon/reactive/openapi/ServerModelReaderTest.java
reactive/openapi/src/test/java/io/helidon/reactive/openapi/TestCors.java
tests/functional/bookstore/src/test/java/io/helidon/tests/bookstore/MainTest.java
tests/functional/request-scope/src/test/java/io/helidon/tests/functional/requestscope/TenantTest.java
tests/integration/mp-gh-3974/src/test/java/io/helidon/tests/integration/gh3974/Gh3974Test.java
removed: assertThat("Response entity should not be an empty string", response.readEntity(String.class), not(""));
tests/integration/mp-ws-services/src/test/java/io/helidon/tests/integration/mp/ws/services/MpServicesTest.java
testJaxrs() -> application is not available on configured socket
tests/integration/security/path-params/src/test/java/io/helidon/tests/integration/security/pathparams/AdminTest.java