Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retries from executor metrics test fix; use the pre-existing countdown latch in GreetService instead #5109

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Remove retries from executor metrics test fix; use the pre-existing countdown latch in GreetService instead #5109

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73471bf
Remove retries from executor metrics test fix; use the pre-existing c…
tjquinno Oct 6, 2022
c4a67e0
Add a second latch; we need both for two different tests
tjquinno Oct 7, 2022
8b9b43f
Add second latch; we need two for different conditions in two differe…
tjquinno Oct 7, 2022
1073b76
Remove executor metrics test - ThreadPoolExecutor methods return esti…
tjquinno Oct 7, 2022
beec90a
Restore the existence check for the executor metrics
tjquinno Oct 7, 2022
8f181b4
Fix typo in comment
tjquinno Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo in comment
  • Loading branch information
@tjquinno
tjquinno committed Oct 7, 2022
commit 8f181b4c161358447d1bea992f49dc00afc006a3
2 changes: 1 addition & 1 deletion metrics/metrics/src/test/java/io/helidon/metrics/TestServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ void checkMetricsForExecutorService() throws InterruptedException {

// Because ThreadPoolExecutor methods are documented as reporting approximations of task counts, etc., we should
// not depend on the values changing in a reasonable time period...or at all. So this test simply makes sure that
// an expected metrics is present.
// an expected metric is present.
String jsonKeyForCompleteTaskCountInThreadPool =
"executor-service.completed-task-count;poolIndex=0;supplierCategory=my-thread-thread-pool-1;supplierIndex=0";

Expand Down