Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: typedef SequenceNumber as bigint #134

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Refactor: typedef SequenceNumber as bigint #134

merged 1 commit into from
Jun 24, 2020

Conversation

heineiuo
Copy link
Owner

@heineiuo heineiuo commented Jun 24, 2020 •
edited
Loading

fix #49

@heineiuo heineiuo merged commit 8f7a5a0 into master Jun 24, 2020
@heineiuo heineiuo deleted the sequence branch June 24, 2020 15:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 146342408

  • 70 of 124 (56.45%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 66.307%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Format.ts 5 6 83.33%
src/VersionSet.ts 2 4 50.0%
src/Database.ts 11 14 78.57%
src/VersionEdit.ts 30 44 68.18%
src/Compaction.ts 10 44 22.73%
Files with Coverage Reduction New Missed Lines %
src/Compaction.ts 1 15.07%
Totals Coverage Status
Change from base Build 145814921: -0.05%
Covered Lines: 2219
Relevant Lines: 3091
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SequenceNumber should deeply use BigInt
2 participants
@heineiuo @coveralls