Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-650 DynamicLoadBalancingPolicy: LatencyAwareHClientPool may throw ... #651

Merged
merged 1 commit into from
Jan 16, 2014

Conversation

jsbret
Copy link

@jsbret jsbret commented Jan 16, 2014

...NoSuchElementException under certain circumstances

Using the poll() method of the LinkedBlockingDeque prevent
NoSuchElementException to be thrown in case the deque is cleared by the
DynamicLoadBalancingPolicy resetThread.

…ow NoSuchElementException under certain circumstances

Using the poll() method of the LinkedBlockingDeque prevent
NoSuchElementException throwing in case the deque is cleared by the
DynamicLoadBalancingPolicy resetThread.
@jsbret
Copy link
Author

jsbret commented Jan 16, 2014

This block of code is only called on client release after a successful operation in Cassandra (HConnectionManager line 312).The value return by poll() have no interest, we only need a method that make little space in the deque to store new value.

Thanks for your response ;-)

@zznate
Copy link
Collaborator

zznate commented Jan 16, 2014

Good point. Thanks!

zznate added a commit that referenced this pull request Jan 16, 2014
issue-650 DynamicLoadBalancingPolicy: LatencyAwareHClientPool may throw ...
@zznate zznate merged commit b7a7041 into hector-client:master Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants