Shrink TextNode(2) (TextureGroup#1495)

Running in iPhone SE Simulator: - ASTextNode: 1360 to 1352 bytes .6% reduction - ASTextNode2: 1360 to 1304 bytes 4.3% redction Shrink stored enum sizes. Group BOOLs near these smaller enums. Override -usingExperiment to return constant instead of never set, but allocated ivar.
hebertialmeida · May 10, 2019 · ad6b6ab · ad6b6ab
1 parent 8d0457c
commit ad6b6ab
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/Source/ASTextNode.mm b/Source/ASTextNode.mm
@@ -208,11 +208,13 @@ @implementation ASTextNode {
 
   NSString *_highlightedLinkAttributeName;
   id _highlightedLinkAttributeValue;
-  ASTextNodeHighlightStyle _highlightStyle;
   NSRange _highlightRange;
   ASHighlightOverlayLayer *_activeHighlightLayer;
 
   UILongPressGestureRecognizer *_longPressGestureRecognizer;
+  ASTextNodeHighlightStyle _highlightStyle;
+  BOOL _longPressCancelsTouches;
+  BOOL _passthroughNonlinkTouches;
 }
 @dynamic placeholderEnabled;
 
@@ -265,6 +267,11 @@ - (void)dealloc
   CGColorRelease(_shadowColor);
 }
 
+- (BOOL)usingExperiment
+{
+    return NO;
+}
+
 #pragma mark - Description
 
 - (NSString *)_plainStringForDescription

diff --git a/Source/ASTextNode2.mm b/Source/ASTextNode2.mm
@@ -170,12 +170,14 @@ @implementation ASTextNode {
 
   NSString *_highlightedLinkAttributeName;
   id _highlightedLinkAttributeValue;
-  ASTextNodeHighlightStyle _highlightStyle;
   NSRange _highlightRange;
   ASHighlightOverlayLayer *_activeHighlightLayer;
   UIColor *_placeholderColor;
 
   UILongPressGestureRecognizer *_longPressGestureRecognizer;
+  ASTextNodeHighlightStyle _highlightStyle;
+  BOOL _longPressCancelsTouches;
+  BOOL _passthroughNonlinkTouches;
 }
 @dynamic placeholderEnabled;
 

diff --git a/Source/ASTextNodeCommon.h b/Source/ASTextNodeCommon.h
@@ -22,7 +22,7 @@
 /**
  * Highlight styles.
  */
-typedef NS_ENUM(NSUInteger, ASTextNodeHighlightStyle) {
+typedef NS_ENUM(unsigned char, ASTextNodeHighlightStyle) {
   /**
    * Highlight style for text on a light background.
    */