cmake: Add fuzzing facilities #43

hebasto · 2023-11-04T19:50:54Z

New CMake variables that affect the build system configuration:

SANITIZERS
BUILD_FUZZ_BINARY
FUZZ

In the light of bitcoin#29189, this PR is no longer based on #41. However, the test/fuzz/script_bitcoin_consensus.cpp might be easily added anytime.

For OSS-Fuzz integration, please refer to hebasto/oss-fuzz#1.

hebasto · 2023-11-04T19:51:53Z

@dergoegge

You might be interested in this PR :)

dergoegge · 2023-11-06T10:43:38Z

I'm pretty sure we will need the equivalent of SANITIZER_LDFLAGS for our oss-fuzz builds: https://github.com/google/oss-fuzz/blob/876d043e5595966bfaca51f39be017d58bb732c5/projects/bitcoin-core/build.sh#L57

hebasto · 2023-11-07T16:38:33Z

Rebased.

src/test/fuzz/util/CMakeLists.txt

hebasto · 2023-11-09T23:53:43Z

Rebased and updated.

hebasto · 2023-11-16T10:55:46Z

Rebased.

hebasto · 2023-12-06T11:39:11Z

Rebased.

hebasto · 2023-12-11T20:51:17Z

Rebased.

theuni · 2023-12-15T18:46:19Z

Ping @fanquake re sanitizers. I'm curious if you think we should drop support for forwarding those flags as well.

fanquake

Ping @fanquake re sanitizers. I'm curious if you think we should drop support for forwarding those flags as well.

@theuni what do you mean re forwarding flags here?

CMakeLists.txt

hebasto · 2024-01-07T19:14:25Z

Rebased.
Description has been updated.
Addressed @dergoegge's and @fanquake's comments.

This PR is ready for review now.

Friendly ping @dergoegge @maflcko @fanquake @TheCharlatan @theuni :)

theuni · 2024-01-09T11:39:42Z

CMakeLists.txt


 option(BUILD_TESTS "Build test_bitcoin executable." ON)
 option(BUILD_BENCH "Build bench_bitcoin executable." ON)
+cmake_dependent_option(BUILD_FUZZ_BINARY "Build fuzz binary." ON "NOT MSVC" OFF)


Note to other reviewers because I had to look up this syntax again. This does the obvious thing: If not msvc, provide the BUILD_FUZZ_BINARY option and set it to ON by default.

https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html

theuni · 2024-01-09T11:40:19Z

CMakeLists.txt

 option(BUILD_TESTS "Build test_bitcoin executable." ON)
 option(BUILD_BENCH "Build bench_bitcoin executable." ON)
+cmake_dependent_option(BUILD_FUZZ_BINARY "Build fuzz binary." ON "NOT MSVC" OFF)
+cmake_dependent_option(FUZZ "Build for fuzzing. Enabling this will disable all other targets and override BUILD_FUZZ_BINARY." OFF "NOT MSVC" OFF)


And this one means: If not msvc, provide the FUZZ option and set it to OFF by default.

src/test/fuzz/CMakeLists.txt

hebasto · 2024-01-09T15:50:25Z

Rebased.

dergoegge · 2024-01-09T16:50:24Z

Tested the oss-fuzz builds for libfuzzer and afl++, looking good!

hebasto · 2024-01-16T13:44:18Z

Rebased.

src/test/fuzz/CMakeLists.txt

hebasto · 2024-01-19T08:23:52Z

As it was requested during yesterday's meeting, the google/oss-fuzz#11516 has been submitted on testing purposes.

UPD. See hebasto/oss-fuzz#1.

hebasto · 2024-01-19T15:46:18Z

As it was requested during yesterday's meeting, the google/oss-fuzz#11516 has been submitted on testing purposes.

UPD. See hebasto/oss-fuzz#1.

https://github.com/hebasto/oss-fuzz/actions/runs/7585104640 is 🟢 :)

theuni

Lightly tested ACK 9b9f562.

I went through the deps to see if anything could be scoped more minimally, but it seems what's here is correct.

63c1bb5 fixup! cmake: Add fuzzing options (Hennadii Stepanov) d31abc2 fixup! ci: Test CMake edge cases (Hennadii Stepanov) Pull request description: From #85 (comment): > **Known Bugs** > > Unfortunately, due to a silent conflict between #43 and #77, providing `-DFUZZ=ON` does not disable the `bitcoin-qt` target. It will be fixed shortly after pushing this branch. Fixed. ACKs for top commit: vasild: ACK 63c1bb5 Tree-SHA512: b3cc2889d0239913de64c170880c97b37966a890d8c4e05f9090485a016b7f9cdf4880d770a234f323d3191b9adda8ed0343c29dfa49b5bb99b0b54481d4335e

dergoegge · 2024-01-30T17:10:27Z

I think we forgot to update the fuzzing docs https://github.com/hebasto/bitcoin/blob/cmake-staging/doc/fuzzing.md

hebasto force-pushed the cmake-staging branch from 1a00d05 to 7dc3874 Compare November 7, 2023 16:20

hebasto force-pushed the 231104-cmake-T branch from 21ef1ab to 2f63087 Compare November 7, 2023 16:38

dergoegge reviewed Nov 9, 2023

View reviewed changes

src/test/fuzz/util/CMakeLists.txt Outdated Show resolved Hide resolved

hebasto force-pushed the cmake-staging branch from d3f3967 to 7400ca5 Compare November 9, 2023 19:04

hebasto force-pushed the 231104-cmake-T branch 2 times, most recently from 424296e to 7f7a472 Compare November 9, 2023 23:52

hebasto mentioned this pull request Nov 10, 2023

Bugfix: configure: Correct check for fuzz binary needing a main function bitcoin/bitcoin#28564

Closed

hebasto force-pushed the 231104-cmake-T branch 3 times, most recently from 631ff31 to 0cc0f9b Compare November 10, 2023 13:38

hebasto mentioned this pull request Nov 10, 2023

CMake-based build system tracking issue bitcoin/bitcoin#28607

Closed

16 tasks

hebasto force-pushed the cmake-staging branch from 6174485 to 4291baa Compare November 16, 2023 10:48

hebasto force-pushed the 231104-cmake-T branch from 0cc0f9b to ee718ad Compare November 16, 2023 10:55

hebasto force-pushed the cmake-staging branch from 399642a to ecf10f1 Compare December 6, 2023 11:25

hebasto force-pushed the 231104-cmake-T branch from ee718ad to 073b93f Compare December 6, 2023 11:38

hebasto force-pushed the cmake-staging branch from ecf10f1 to 2af94fb Compare December 11, 2023 12:37

hebasto force-pushed the 231104-cmake-T branch from 073b93f to 7d33a75 Compare December 11, 2023 20:50

hebasto force-pushed the cmake-staging branch from d2e741e to 1958b54 Compare December 12, 2023 14:41

hebasto force-pushed the 231104-cmake-T branch from 7d33a75 to 7504618 Compare December 12, 2023 15:09

fanquake reviewed Dec 18, 2023

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

hebasto force-pushed the 231104-cmake-T branch from 7504618 to 910fd7a Compare January 7, 2024 18:59

hebasto marked this pull request as ready for review January 7, 2024 19:12

theuni reviewed Jan 9, 2024

View reviewed changes

hebasto force-pushed the cmake-staging branch from bfc9375 to 67ceebb Compare January 9, 2024 15:47

hebasto force-pushed the 231104-cmake-T branch from 910fd7a to c06f421 Compare January 9, 2024 15:50

hebasto force-pushed the cmake-staging branch from 67ceebb to 203a3ab Compare January 16, 2024 13:23

hebasto force-pushed the 231104-cmake-T branch from c06f421 to e3536de Compare January 16, 2024 13:43

hebasto force-pushed the 231104-cmake-T branch from e3536de to 86bca52 Compare January 16, 2024 14:01

fanquake reviewed Jan 18, 2024

View reviewed changes

src/test/fuzz/CMakeLists.txt Outdated Show resolved Hide resolved

hebasto added 2 commits January 19, 2024 07:51

cmake: Add SANITIZERS option

ea7861e

cmake: Add fuzzing options

9b9f562

hebasto mentioned this pull request Jan 19, 2024

bitcoin-core: Migrate to CMake google/oss-fuzz#11516

Closed

hebasto force-pushed the 231104-cmake-T branch from 86bca52 to 9b9f562 Compare January 19, 2024 09:21

hebasto mentioned this pull request Jan 19, 2024

bitcoin-core: Migrate to CMake hebasto/oss-fuzz#1

Closed

theuni approved these changes Jan 19, 2024

View reviewed changes

hebasto merged commit 3659fca into cmake-staging Jan 25, 2024

This was referenced Jan 26, 2024

cmake: Regular rebasing of the cmake-staging branch #85

Closed

cmake: Bug fixes #87

Merged

cmake: Add fuzzing facilities #43

cmake: Add fuzzing facilities #43

Uh oh!

Conversation

hebasto commented Nov 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Nov 4, 2023

Uh oh!

dergoegge commented Nov 6, 2023

Uh oh!

hebasto commented Nov 7, 2023

Uh oh!

Uh oh!

hebasto commented Nov 9, 2023

Uh oh!

hebasto commented Nov 16, 2023

Uh oh!

hebasto commented Dec 6, 2023

Uh oh!

hebasto commented Dec 11, 2023

Uh oh!

theuni commented Dec 15, 2023

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented Jan 7, 2024

Uh oh!

theuni Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

hebasto Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

theuni Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hebasto commented Jan 9, 2024

Uh oh!

dergoegge commented Jan 9, 2024

Uh oh!

hebasto commented Jan 16, 2024

Uh oh!

Uh oh!

hebasto commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Jan 19, 2024

Uh oh!

theuni left a comment

Choose a reason for hiding this comment

Uh oh!

dergoegge commented Jan 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hebasto commented Nov 4, 2023 •

edited

Loading

hebasto commented Jan 19, 2024 •

edited

Loading