Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake, ci: Disable qt5 feature temporarily #137

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Apr 2, 2024

The xz-backdoor affects our vcpkg dependencies. So disabling some of them temporarily to unlock the CI.

Copy link

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 24056ae

I see currently "Win64, VS 2022" both Static and Dynamic CIs failing due to that. Temporarily disabling package liblzma makes sense.

image

eg CI error logs

@hebasto hebasto merged commit 4d7130d into cmake-staging Apr 3, 2024
29 checks passed
hebasto added a commit that referenced this pull request Apr 6, 2024
b2ccf9d Revert "cmake, ci: Disable qt5 feature temporarily" (Hennadii Stepanov)
ede8a7d cmake, msvc: Override `liblzma` version (Hennadii Stepanov)

Pull request description:

  This is an alternative to #137, which does not disable GUI for MSVC builds.

ACKs for top commit:
  m3dwards:
    ACK b2ccf9d

Tree-SHA512: d4e6fff17a886c1b44ee3bc7affae87372345dece11ebe5d3a8b9964438205b2f271bd38fc5948e9e7e82aa2c89fa62aa48e4660a7b89c7a9bb1e81bd56138df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants