Merge pull request sequelize#1298 from janmeier/badPooling

Fix for connection errors when using replication
heartsentwined · Jan 26, 2014 · fdc5859 · fdc5859
2 parents 2720578 + 7ad4892
commit fdc5859
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 7 deletions.
diff --git a/lib/dialects/mariadb/connector-manager.js b/lib/dialects/mariadb/connector-manager.js
@@ -90,7 +90,10 @@ module.exports = (function() {
             var config = self.config.replication.read[reads++]
 
             connect.call(self, function (err, connection) {
-              connection.queryType = 'read'
+              if (connection) {
+                connection.queryType = 'read'
+              }
+
               done(null, connection)
             }, config)
           },
@@ -106,7 +109,10 @@ module.exports = (function() {
           name: 'sequelize-write',
           create: function (done) {
             connect.call(self, function (err, connection) {
-              connection.queryType = 'write'
+              if (connection) {
+                connection.queryType = 'write'
+              }
+
               done(null, connection)
             }, self.config.replication.write)
           },

diff --git a/lib/dialects/mysql/connector-manager.js b/lib/dialects/mysql/connector-manager.js
@@ -88,8 +88,11 @@ module.exports = (function() {
             var config = self.config.replication.read[reads++];
 
             connect.call(self, function (err, connection) {
-              connection.queryType = 'read'
-              done(null, connection)
+              if (connection) {
+                connection.queryType = 'read'
+              }
+
+              done(err, connection)
             }, config);
           },
           destroy: function(client) {
@@ -104,8 +107,11 @@ module.exports = (function() {
           name: 'sequelize-write',
           create: function (done) {
             connect.call(self, function (err, connection) {
-              connection.queryType = 'write'
-              done(null, connection)
+              if (connection) {
+                connection.queryType = 'read'
+              }
+
+              done(err, connection)
             }, self.config.replication.write);
           },
           destroy: function(client) {
@@ -296,7 +302,6 @@ module.exports = (function() {
     }
 
     var connection = mysql.createConnection(connectionConfig);
-
     connection.connect(function(err) {
       if (err) {
         switch(err.code) {

diff --git a/test/sequelize.test.js b/test/sequelize.test.js
@@ -64,6 +64,22 @@ describe(Support.getTestDialectTeaser("Sequelize"), function () {
               done()
             })
         })
+
+        it('triggers the error event when using replication', function (done) {
+          new Sequelize('sequelize', null, null, {
+            replication: {
+              read: {
+                host: 'localhost',
+                username: 'omg',
+                password: 'lol'
+              }
+            }
+          }).authenticate()
+            .complete(function(err, result) {
+              expect(err).to.not.be.null
+              done()
+            })
+        })
       })
     })
   }