Support procs for sign_in_after_reset_password config#5653
Open
excid3 wants to merge 3 commits intoheartcombo:mainfrom
Open
Support procs for sign_in_after_reset_password config#5653excid3 wants to merge 3 commits intoheartcombo:mainfrom
excid3 wants to merge 3 commits intoheartcombo:mainfrom
Conversation
excid3
force-pushed
the
sign-in-after-reset-password-proc
branch
2 times, most recently
from
cb65878 to
50e4ccd
Compare
excid3
force-pushed
the
sign-in-after-reset-password-proc
branch
from
50e4ccd to
82a3d23
Compare
nunommc
reviewed
Nov 27, 2023
Comment on lines
+56
to
+57
| value = resource_class.sign_in_after_reset_password | ||
| value.respond_to?(:call) ? value.call(resource) : value |
There was a problem hiding this comment.
wdyt about renaming the variable to setting or config?
Suggested change
| value = resource_class.sign_in_after_reset_password | |
| value.respond_to?(:call) ? value.call(resource) : value | |
| setting = resource_class.sign_in_after_reset_password | |
| setting.respond_to?(:call) ? setting.call(resource) : setting |
Co-authored-by: Nuno Costa <nuno.mmc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using MFA with Devise, it would be great to support callable objects in the
sign_in_after_reset_passwordconfig.Example
Originally, I had to override the passwords controller to change this behavior but it's much cleaner if Devise supports procs, lambdas, or any other callable object.
The
resourceis passed as an argument so this can be applied based upon user preferences.