Add failing test case for bad parameter sanitizing when failing to login#2452
Conversation
|
@latortuga Great work! Can you provide a fix as well @latortuga? We should just add the missing ones to our list. :) |
|
@latortuga Hey, can you help us tidy this up? Feel free to merge your tests and the proper fix. :) ❤️ |
|
Yes, I'll try to get it today or tomorrow. I've been out of town and work has been pretty busy, sorry for the delay! |
This includes a failing test case that hooks into ActiveSupport Notifications to catch the param permit error.
…ogin Add failing test case for bad parameter sanitizing when failing to login
|
Guys please help me with this: http://stackoverflow.com/questions/17631659/devise-custom-attributes-and-strong-parameters |
|
It is pretty hard to help if you don't include at least your Devise and Rails versions. Please take a look at our |
|
I'm sorry, my bad. Here it is: Rails 4 and Devise 3.0.0rc |
|
Have you tried Devise 3.0.0 final? It was launched this sunday. |
|
Nice, didn't know that. I'll try and tell about it later. Thanks |
Failing test for #2440. This was hard to track down because the implementation for StrongParameters'
action_on_unpermitted_parameterseither doesn't work or isn't documented correctly and it doesn't seem to raise an error as expected.