refactoring CLI commands and documenting #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those arguments were ignored, while appearing in the documentation
The only occurence of `keyEncoding` is commented-out in lib/db.js
by applying the limit within the stream, after applying the match filter, instead of passing the limit argument to the stream itself, resulting in getting an already limitted amount of elements to match on. Weirdly, we also need to prevent passing a limit option to the db, as it was limiting the number of results the stream could get
…ues commands into a single block, to make it easier to have a consistent interface: - a match option can passed to any of --all, --keys, --values - all commands can have a --start, an --end, and a --limit
by refusing to use the current directory if no LevelDB database exists already unless the path is passed explicitly
allowing to use it for dump imports Also being more tolerant on the output, to accept the output of a --all dump
maxlath
force-pushed
the
master
branch
2 times, most recently
from
0ccb46a to
707813f
Compare
Author
|
re-opened as #59 with a different branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! I was struggling to use the CLI, so I dug into the code and went into refactoring berserk mode: it might be a lot of changes, so feel welcome to merge or cherry-pick whatever make sense to you :)
Summary:
--createReadStreamcommand into--allto distinct it from--keysand--valuesstreams--linemode for--keys--lengthcommand--batchoption and let it take operations from a file