Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: util: Add combineClusterListErrors #2423

Merged
merged 1 commit into from
Oct 15, 2024
Merged

frontend: util: Add combineClusterListErrors #2423

merged 1 commit into from
Oct 15, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Oct 14, 2024

For errors, we may need to combine several cluster->errors
objects into a single object.

This is in preparation for multi cluster.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 14, 2024
@illume illume added frontend Issues related to the frontend multi Multi cluster aggregated view labels Oct 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
For errors, we may need to combine several cluster->errors
objects into a single object.

This is in preparation for multi cluster.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Co-authored-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@illume
Copy link
Collaborator Author

illume commented Oct 15, 2024

(rebased against main to fix conflicts)

@illume
Copy link
Collaborator Author

illume commented Oct 15, 2024

The Build Container CI failure is an unrelated problem with github/ubuntu.

@illume illume merged commit 254aeb9 into main Oct 15, 2024
17 of 18 checks passed
@illume illume deleted the combine-multi branch October 15, 2024 11:24
@illume illume mentioned this pull request Oct 17, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer multi Multi cluster aggregated view size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants