app: frontend: plugins: Add runCommand for shell commands in Electron app #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… app So that some local shell commands can be run from inside a plugin. This communicates the process interaction with the Electron app render process via ipc. The interface exposed is a subset of the node spawn() which is what is used on the app side. It only implements the parts which are already used by the plugin we have in mind. The interface supports streaming stdout and stderr, and getting exit codes. Note, this supports running multiple commands at the same time. The complexities of this are hidden to the user of runCommand. It limits the commands that can be run to only minikube and az so far. If there is a need for more this can be extended later. This is intended as a way to limit potential misuse. The app-menu example plugin has been extended to add a minikube menu which displays minikube status. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
added
enhancement
|
Thanks for the review :) I'll make those changes. |
|
@knrt10 thanks, I addressed your notes. |
knrt10
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Awesome work @illume . Tested it.
Note: Not in the scope of this PR, but maybe we can edit the plugin later to show app menu for the current cluster that it is in. i.e. if there are multiple clusters when open it should show its status.
For example, here knrt10 cluster is opened it should show it's status
Again, it's not in the scope of this PR, just something we could improve later.
|
fixes #1670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that some local shell commands can be run from inside a plugin.
This communicates the process interaction with the Electron app render process via ipc.
The interface exposed is a subset of the node spawn() which is what is used on the app side. It only implements the parts which are already used by the plugin we have in mind.
The interface supports streaming stdout and stderr, and getting exit codes.
Note, this supports running multiple commands at the same time. The complexities of this are hidden to the user of runCommand.
It limits the commands that can be run to only minikube and az so far. If there is a need for more this can be extended later. This is intended as a way to limit potential misuse.
How to test?
The app-menu example plugin has been extended to add a minikube menu which displays minikube status.
Now in a separate terminal
cd app npm i npm startNow with the app-menus example plugin there should be a minikube menu shown which when extended shows minikube status.
For the create cluster feature #1682