Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding between img and the border #353

Closed

Conversation

willigro
Copy link

I needed apply a spacing between the image and the border.
So, i maked a propriety of padding (mRadiusPadding) that give this space, kept the image without cut.

@JcMinarro
Copy link

Hi @hdodenhof would be great to have this feature on the lib.
Were you able to review this PR?

@Magno-Ramos
Copy link

this looks great

@hdodenhof
Copy link
Owner

@willigro Thanks for your work on this!

I'll quote a statement a made earlier in #226:

I won't implement this directly as I'd like to keep this whole thing as simple to use as possible and part of that is keeping the number of options limited. I recommend using that workaround - you could also create a custom ViewGroup that completely wraps the magic.

I still think this is a niche use case that doesn't warrant the added complexity, esp. as there's a simple way to achieve the desired state in #133.

@hdodenhof hdodenhof closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants