Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented Apr 12, 2023

Motivation

Fix #842

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (fde784d) 87.79% compared to head (f7e79d7) 87.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #848      +/-   ##
==========================================
+ Coverage   87.79%   87.81%   +0.01%     
==========================================
  Files          44       44              
  Lines        8950     8959       +9     
  Branches     2695     2698       +3     
==========================================
+ Hits         7858     7867       +9     
  Misses        779      779              
  Partials      313      313              
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5tools.py 82.47% <100.00%> (+0.03%) ⬆️
src/hdmf/backends/io.py 96.61% <100.00%> (+0.24%) ⬆️
src/hdmf/build/manager.py 85.30% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly rly requested a review from oruebel April 13, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Export with link_data=False does not copy data

3 participants