fix: show all matching users in CreatedBy filter popup #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
When typing in the CreatedBy filter popup to search for users, some usernames were being hidden even when they matched the search text. This was because the filtering was restricted to only show users that were either previously selected or referenced in existing documents. This change removes that restriction when searching, allowing all users that match the search pattern to be shown in the popup. Co-Authored-By: aonnikov@hardcoreeng.com <aonnikov@hardcoreeng.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix username filtering in CreatedBy filter popup
Description
When typing in the CreatedBy filter popup to search for users, some usernames were being hidden even when they matched the search text. This was happening because the filtering was restricted to only show users that were either previously selected or referenced in existing documents.
This change removes that restriction when searching, allowing all users that match the search pattern to be shown in the popup.
Changes
ObjectFilter.svelteto show all matching users when searching, not just those in the targets setTesting
The changes have been tested manually to verify:
Link to Devin run
https://app.devin.ai/sessions/ae05206c8c514a52bb3a94bce3f646bf
Huly®: UBERF-8984