feat: use hot prowser instance to improve stability#10976
Open
aonnikov wants to merge 1 commit into
Open
Conversation
|
Connected to Huly®: UBERF-16665 |
aonnikov
force-pushed
the
feat-print-stability
branch
from
July 14, 2026 05:36
aeae592 to
7e56ae3
Compare
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
aonnikov
force-pushed
the
feat-print-stability
branch
from
July 14, 2026 07:30
7e56ae3 to
09e3599
Compare
| return await this.createPageInBrowser(browser) | ||
| } catch (err) { | ||
| if (this.browser === browser) { | ||
| await this.resetBrowser(browser) |
Member
There was a problem hiding this comment.
Is it safe in case when PRINT_CONCURRENCY > 1?
|
|
||
| import config from './config' | ||
|
|
||
| const BROWSER_PAGE_INIT_TIMEOUT_MS = 2000 |
Member
There was a problem hiding this comment.
Should we make this timeout configurable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.