fix: add CockroachDB init Job for user/privilege creation - #329
Open
krajtar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CockroachDB runs with
start-single-node --insecure. The user and database are created implicitly on first PV initialization, but there is no guarantee that:selfhost) has been created with the password from the Secrethulykvs)When ArgoCD recreates the cockroach pod (or the PV is lost), the user/privileges must be re-established. Currently there is no mechanism for this — it requires manual SQL intervention.
Fix
Add a Helm post-install,post-upgrade hook Job that:
huly.waitForCockroachhelper)The job uses
helm.sh/hook-delete-policy: before-hook-creation,hook-succeededso it runs on every upgrade but cleans up after itself.Backward compatibility
IF NOT EXISTS)cockroach.image