Add `as` prop for renaming HTML tag #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

harshzalavadiya merged 1 commit into hc-oss:master from devinschulz:rename-html-tag

Sep 8, 2022

Contributor

devinschulz commented Apr 5, 2022

In some cases, when using the skeleton loader within a p tag, React will log this warning:

console.error
    Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
        at div
        at SkeletonLoader (/node_modules/tiny-skeleton-loader-react/src/index.tsx:16:3)
        at div
        at p

I propose allowing developers to rename the div by the as prop, like so:

<SkeletonLoader as="span" />


          Add the ability to rename the html tag

ec79746

harshzalavadiya merged commit c93a249 into hc-oss:master

devinschulz deleted the rename-html-tag branch

September 8, 2022 17:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet