Fix error with fake selection (codex-team#595)

* fix bag fakeSelection (codex-team#590)
hboylan · Jan 22, 2019 · 3842595 · 3842595
1 parent 67d5571
commit 3842595
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/dist/codex-editor.js b/dist/codex-editor.js
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+### 2.7.29
+
+- `Fix` Fixed selection behavior when text has modifiers from Inline Toolbar
+
 ### 2.7.28 
 
 - `New` [Tools Validation](https://github.com/codex-team/codex.editor/blob/master/docs/tools.md#validate-optional) is added.

diff --git a/src/components/selection.ts b/src/components/selection.ts
@@ -225,9 +225,7 @@ export default class SelectionUtils {
     if (!this.isFakeBackgroundEnabled) {
       return;
     }
-    const fakeBack = this.findParentTag('SPAN');
 
-    fakeBack.style.paddingTop = '';
     this.isFakeBackgroundEnabled = false;
     document.execCommand(this.commandRemoveFormat);
   }
@@ -237,10 +235,7 @@ export default class SelectionUtils {
    */
   public setFakeBackground() {
     document.execCommand(this.commandBackground, false, '#a8d6ff');
-    const fakeBack = this.findParentTag('SPAN');
 
-    // The matched value to be slightly compared with the actual height of the selection
-    fakeBack.style.paddingTop = '0.30em';
     this.isFakeBackgroundEnabled = true;
   }