use poetry for build and deps #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
force-pushed
the
poetry
branch
3 times, most recently
from
d19cca9
to
1dfd3a9
Compare
This changes the build system from setuptools to poetry. This allows us to avoid duplicating the package dependencies 3 times and also include a lock file so that devs are working from the same package versions.
Several dependencies were not added. This is evident when trying to build the docs without installing main dependencies. Also simplify and move after imports while we are touching this.
The TypedDict type breaks autodoc mocks in sphinx, so we can avoid the problem by ensuing that sphinx uses python >=3.8 and only use the typing-extensions package for python 3.7.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build system from setuptools to poetry. This allows
us to avoid duplicating the package dependencies 3 times and also
include a lock file so that devs are working from the same package
versions.