release v0.16.0

CHANGELOG.rst

@@ -10,6 +10,30 @@ and this project adheres to `Semantic Versioning <https://semver.org/spec/v2.0.0
 `Unreleased`_
 =============
 
+`0.16.0`_ (2022-08-31)
+======================
+
+Added
+-----
+* Added ``BleakGattCharacteristic.max_write_without_response_size`` property. Fixes #738.
+
+Fixed
+-----
+* Fixed regression in v0.15 where devices removed from BlueZ while scanning
+  were still listed in ``BleakScanner.discovered_devices``. Fixes #942.
+* Fixed possible bad connection state in BlueZ backend. Fixes #951.
+
+Changed
+-------
+* Made BlueZ D-Bus signal callback logging lazy to improve performance. Merged #912.
+* Switch to using async_timeout instead of asyncio.wait_for for performance. Merged #916.
+* Improved performance of ``BlueZManager.get_services()``. Fixes #927.
+
+Removed
+-------
+* Removed explicit inheritance from object in class declarations. Merged #922.
+* Removed first seen filter in ``BleakScanner`` detection callbacks on BlueZ backend. Merged #964.
+
 `0.15.1`_ (2022-08-03)
 ======================
 
@@ -19,6 +43,7 @@ Fixed
 * Handle the race in the BlueZ D-Bus backend where the device disconnects during
   the connection process which presented as ``Failed to cancel connection``. Merged #919.
 * Ensure the BlueZ D-Bus scanner can reconnect after DBus disconnection. Merged #920.
+* Adjust default timeout for ``read_gatt_char()`` with CoreBluetooth to 20s. Fixes #926.
 
 
 `0.15.0`_ (2022-07-29)
@@ -722,7 +747,8 @@ Fixed
 * Bleak created.
 
 
-.. _Unreleased: https://github.com/hbldh/bleak/compare/v0.15.1...develop
+.. _Unreleased: https://github.com/hbldh/bleak/compare/v0.16.0...develop
+.. _0.16.0: https://github.com/hbldh/bleak/compare/v0.15.1...v0.16.0
 .. _0.15.1: https://github.com/hbldh/bleak/compare/v0.15.0...v0.15.1
 .. _0.15.0: https://github.com/hbldh/bleak/compare/v0.14.3...v0.15.0
 .. _0.14.3: https://github.com/hbldh/bleak/compare/v0.14.2...v0.14.3

Pipfile

@@ -4,6 +4,7 @@ verify_ssl = true
 name = "pypi"
 
 [packages]
+async_timeout = ">=4.0.1"
 typing-extensions = ">=4.2.0"
 dbus-next = {version = ">=0.2.2", sys_platform = "== 'linux'"}
 pyobjc-core = {version = ">=7.0.1", sys_platform = "== 'darwin'"}

bleak/__version__.py

@@ -1,3 +1,3 @@
 # -*- coding: utf-8 -*-
 
-__version__ = "0.15.1"
+__version__ = "0.16.0"

bleak/backends/bluezdbus/characteristic.py

@@ -1,10 +1,10 @@
+from typing import List, Union
 from uuid import UUID
-from typing import Union, List
-
-from bleak.backends.bluezdbus.utils import extract_service_handle_from_path
-from bleak.backends.characteristic import BleakGATTCharacteristic
-from bleak.backends.descriptor import BleakGATTDescriptor
 
+from ..characteristic import BleakGATTCharacteristic
+from ..descriptor import BleakGATTDescriptor
+from .defs import GattCharacteristic1
+from .utils import extract_service_handle_from_path
 
 _GattCharacteristicsFlagsEnum = {
     0x0001: "broadcast",
@@ -31,9 +31,16 @@ class BleakGATTCharacteristicBlueZDBus(BleakGATTCharacteristic):
     """GATT Characteristic implementation for the BlueZ DBus backend"""
 
     def __init__(
-        self, obj: dict, object_path: str, service_uuid: str, service_handle: int
+        self,
+        obj: GattCharacteristic1,
+        object_path: str,
+        service_uuid: str,
+        service_handle: int,
+        max_write_without_response_size: int,
     ):
-        super(BleakGATTCharacteristicBlueZDBus, self).__init__(obj)
+        super(BleakGATTCharacteristicBlueZDBus, self).__init__(
+            obj, max_write_without_response_size
+        )
         self.__descriptors = []
         self.__path = object_path
         self.__service_uuid = service_uuid

bleak/backends/bluezdbus/client.py

@@ -10,6 +10,8 @@
 from typing import Callable, Optional, Union
 from uuid import UUID
 
+import async_timeout
+
 from dbus_next.aio import MessageBus
 from dbus_next.constants import BusType, ErrorType
 from dbus_next.message import Message
@@ -153,22 +155,31 @@ def on_value_changed(char_path: str, value: bytes) -> None:
 
         try:
             try:
-                reply = await asyncio.wait_for(
-                    self._bus.call(
+                async with async_timeout.timeout(timeout):
+                    reply = await self._bus.call(
                         Message(
                             destination=defs.BLUEZ_SERVICE,
                             interface=defs.DEVICE_INTERFACE,
                             path=self._device_path,
                             member="Connect",
                         )
-                    ),
-                    timeout,
-                )
+                    )
                 assert_reply(reply)
 
                 self._is_connected = True
+
+                # Create a task that runs until the device is disconnected.
+                self._disconnect_monitor_event = asyncio.Event()
+                asyncio.ensure_future(self._disconnect_monitor())
+
+                await self.get_services()
+
+                return True
             except BaseException:
-                # calling Disconnect cancels any pending connect request
+                # Calling Disconnect cancels any pending connect request. Also,
+                # if connection was successful but get_services() raises (e.g.
+                # because task was cancelled), the we still need to disconnect
+                # before passing on the exception.
                 if self._bus:
                     # If disconnected callback already fired, this will be a no-op
                     # since self._bus will be None and the _cleanup_all call will
@@ -196,15 +207,6 @@ def on_value_changed(char_path: str, value: bytes) -> None:
                         )
 
                 raise
-
-            # Create a task that runs until the device is disconnected.
-            self._disconnect_monitor_event = asyncio.Event()
-            asyncio.ensure_future(self._disconnect_monitor())
-
-            # Get all services. This means making the actual connection.
-            await self.get_services()
-
-            return True
         except BaseException:
             self._cleanup_all()
             raise
@@ -294,7 +296,8 @@ async def disconnect(self) -> bool:
         if self._disconnecting_event:
             # another call to disconnect() is already in progress
             logger.debug(f"already in progress ({self._device_path})")
-            await asyncio.wait_for(self._disconnecting_event.wait(), timeout=10)
+            async with async_timeout.timeout(10):
+                await self._disconnecting_event.wait()
         elif self.is_connected:
             self._disconnecting_event = asyncio.Event()
             try:
@@ -308,7 +311,8 @@ async def disconnect(self) -> bool:
                     )
                 )
                 assert_reply(reply)
-                await asyncio.wait_for(self._disconnecting_event.wait(), timeout=10)
+                async with async_timeout.timeout(10):
+                    await self._disconnecting_event.wait()
             finally:
                 self._disconnecting_event = None