Index BlueZ advertisement_callbacks by adapter

[bdraco]

• Instead of doing a linear search of all the callbacks to find the one for the adapter, store them in a dict so the adapter path can be looked up

• Remove unused arg from _run_advertisement_callbacks

• If the pull request adds functionality, the docs should be updated.

• Modify the CHANGELOG.rst, describing your changes as is specified by the
  guidelines in that document.

• The pull request should work for Python 3.8+ on the following platforms:

  • Windows 10, version 16299 (Fall Creators Update) and greater
  • Linux distributions with BlueZ >= 5.43
  • OS X / macOS >= 10.11

• Squash all your commits on your PR branch, if the commits are not solving
  different problems and you are committing them in the same PR. In that case,
  consider making several PRs instead.

• Feel free to add your name as a contributor to the AUTHORS.rst file!

[bdraco]

Average time complexity should now be: O(callbacks) instead of O(adapters * callbacks)

[dlech]

Do you have before and after flamegraphs or something like that showing the difference?

[bdraco]

#1632 (comment)

[dlech]

Do you have before and after flamegraphs or something like that showing the difference?

[bdraco]

#1632 (comment)

Running with 6 Bluetooth adapters its ~28% less time spent in _run_advertisement_callbacks processing ~8000 messages per minute as measured with cProfile.

It can be roughly benchmarked with

import timeit
from collections import defaultdict


def callback():
    pass


advertisement_callbacks: defaultdict[str, list] = defaultdict(list)

test_adapter = "/org/bluez/hci9"

for i in range(10):
    advertisement_callbacks[f"/org/bluez/hci{i}"] = [callback]

advertisement_callbacks_orig = [
    (callback, adapter_path)
    for callback, adapter_path in advertisement_callbacks.items()
]


def new():
    for callback in advertisement_callbacks[test_adapter]:
        pass


def orig():
    for callback, adapter_path in advertisement_callbacks_orig:
        if adapter_path != test_adapter:
            continue


print(timeit.timeit(orig, number=1000000))
print(timeit.timeit(new, number=1000000))

orig

0.1742814159952104

new

0.042215333989588544

[dlech]

Thanks!

[bdraco]

Thanks